-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed / Completed pod support #29
Failed / Completed pod support #29
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 56.48% 59.10% +2.62%
==========================================
Files 4 5 +1
Lines 825 939 +114
==========================================
+ Hits 466 555 +89
- Misses 304 319 +15
- Partials 55 65 +10
Continue to review full report at Codecov.
|
* initial implementation * fixes * Namespace exclusion * test sorting * test fixes * exclusion granularity * add vendor dependencies * fixes * Update podreaper.go * Update README.md * Update README.md * Update README.md * add namespaces rbac * fix readme typos
|---|:---:|:---:| | ||
| governor.keikoproj.io/disable-pod-reaper | "true" | disable all features | ||
| governor.keikoproj.io/disable-completed-pod-reap | "true" | disable completed pod reaping | ||
| governor.keikoproj.io/disable-completed-pod-reap | "true" | disable failed pod reaping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be governor.keikoproj.io/disable-failed-pod-reap
?
Fixes #27
Fixes #28